Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal: renesas: rz: Initial support for I2C #55

Merged

Conversation

nhutnguyenkc
Copy link
Contributor

Initial HAL support for I2C

Copy link
Collaborator

@thaoluonguw thaoluonguw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@nhutnguyenkc nhutnguyenkc force-pushed the support_renesas_rzg_i2c branch from 5796545 to 247d994 Compare December 24, 2024 06:24
@KhiemNguyenT
Copy link
Collaborator

@nhutnguyenkc , to get it merged, please resolve the conflict.


#define RIIC_MASTER_CFG_PARAM_CHECKING_ENABLE (BSP_CFG_PARAM_CHECKING_ENABLE)
#define RIIC_MASTER_CFG_DMAC_ENABLE (0)
#define RIIC_MASTER_CFG_ADDR_MODE_10_BIT_ENABLE (0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhutnguyenkc , is it for now I2C driver of RZ will not support the 10 bit addressing mode?

Copy link
Contributor Author

@nhutnguyenkc nhutnguyenkc Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duynguyenxa , thank you, it is already supported. I have enabled 10-bit addressing mode and already passed i2c test.

Initial HAL support for I2C

Signed-off-by: Hoang Nguyen <hoang.nguyen.jx@bp.renesas.com>
Signed-off-by: Nhut Nguyen <nhut.nguyen.kc@renesas.com>
@nhutnguyenkc nhutnguyenkc force-pushed the support_renesas_rzg_i2c branch from 247d994 to 9143133 Compare December 24, 2024 09:58
@nhutnguyenkc
Copy link
Contributor Author

@KhiemNguyenT , I have rebased to resolve the conflict. Please kindly check again and merge it.

@KhiemNguyenT KhiemNguyenT self-requested a review December 24, 2024 10:31
@KhiemNguyenT KhiemNguyenT merged commit 5022c6c into zephyrproject-rtos:main Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants